Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "complete source" instead of top-level expression #199

Merged
merged 5 commits into from
Jul 3, 2024
Merged

Use "complete source" instead of top-level expression #199

merged 5 commits into from
Jul 3, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Jul 2, 2024

Fixes #194

@hadley hadley requested review from lionel- and cderv July 2, 2024 13:59
lionel-
lionel- approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

R/evaluate.R Outdated Show resolved Hide resolved
hadley and others added 2 commits July 3, 2024 07:22
@hadley hadley merged commit 212acdb into main Jul 3, 2024
13 checks passed
@hadley hadley deleted the better-term branch July 3, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cderv cderv cderv approved these changes

@lionel- lionel- lionel- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better name for TLE?
3 participants
@hadley @lionel- @cderv